Initial support for using range.getClientRects to measure text. by nightwing · Pull Request #5922 · ajaxorg/ace

nightwing · 2026-02-22T17:57:41Z

xyos

lgtm

github-actions · 2026-05-02T08:37:38Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

codecov · 2026-05-02T08:39:05Z

Codecov Report

❌ Patch coverage is 93.81313% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.94%. Comparing base (f82010e) to head (8f9018c).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
src/layer/font_metrics.js	93.18%	36 Missing ⚠️
src/virtual_renderer.js	88.37%	10 Missing ⚠️
src/ext/diff/inline_diff_view.js	77.77%	2 Missing ⚠️
src/layer/marker.js	93.75%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5922      +/-   ##
==========================================
+ Coverage   93.73%   93.94%   +0.21%     
==========================================
  Files         641      647       +6     
  Lines      138167   140265    +2098     
  Branches    14561    14705     +144     
==========================================
+ Hits       129510   131777    +2267     
+ Misses       8657     8488     -169

Flag	Coverage Δ
unittests	`93.94% <93.81%> (+0.21%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-05-02T09:05:10Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

github-actions · 2026-05-03T14:06:29Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

github-actions · 2026-05-04T10:03:10Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

github-actions · 2026-05-05T14:08:50Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

… calculations # Conflicts: # src/virtual_renderer.js

github-actions · 2026-07-06T18:04:04Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

…` and related methods

…ed text-to-pixel accuracy and update related cursor positioning logic fix: remove unused `offsetX` parameter from `screenToDocumentPosition` and related methods fix: set $fontMetrics to session instead of adding new selection methods fix: refine cursor positioning using pixel-based calculations # Conflicts: # src/layer/font_metrics.js # src/selection.js

github-actions · 2026-07-08T17:24:01Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

github-actions · 2026-07-09T15:19:52Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

github-actions · 2026-07-10T06:24:12Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

github-actions · 2026-07-10T07:03:08Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

github-actions · 2026-07-10T14:35:42Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

github-actions · 2026-07-10T14:36:43Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

github-actions · 2026-07-10T15:42:33Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

github-actions · 2026-07-10T16:23:57Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

github-actions · 2026-07-12T23:07:58Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

xyos

Nice work, this is awesome!

I built #5988 on an earlier snapshot of this branch, so below are a few things I hit while testing grapheme/bidi edge cases against real browser measurements. Most are small and cherry-pickable from #5988. Details inline.

Once this merges I'd like us to review and maybe do a follow-up PR picking up the rest of #5988: the grapheme-cluster model (Intl.Segmenter-based helpers in lib/lang, cluster-snapping moveCursorTo, cluster-aware $getDisplayTokens/$computeWrapSplits, $alignTokensToClusters). It touches the same code this PR rewrites, so rebasing it on top of merged master is cleaner than growing this PR's scope. With the current branch a wrap limit crossing 👨‍👩‍👧‍👦 still splits its 11 code units across screen rows, and moveCursorTo only snaps surrogate pairs, not ZWJ/combining-mark clusters; the follow-up addresses #460, #4142, #5431, #4602, #3753, #3866, #3617.

xyos · 2026-07-13T20:26:32Z

    $renderToken(parent, screenColumn, token, value) {
        var self = this;
-        var re = /(\t)|( +)|([\x00-\x1f\x80-\xa0\xad\u1680\u180E\u2000-\u200f\u2028\u2029\u202F\u205F\uFEFF\uFFF9-\uFFFC\u2066\u2067\u2068\u202A\u202B\u202D\u202E\u202C\u2069\u2060\u2061\u2062\u2063\u2064\u206A\u206B\u206B\u206C\u206D\u206E\u206F]+)|(\u3000)|([\u1100-\u115F\u11A3-\u11A7\u11FA-\u11FF\u2329-\u232A\u2E80-\u2E99\u2E9B-\u2EF3\u2F00-\u2FD5\u2FF0-\u2FFB\u3001-\u303E\u3041-\u3096\u3099-\u30FF\u3105-\u312D\u3131-\u318E\u3190-\u31BA\u31C0-\u31E3\u31F0-\u321E\u3220-\u3247\u3250-\u32FE\u3300-\u4DBF\u4E00-\uA48C\uA490-\uA4C6\uA960-\uA97C\uAC00-\uD7A3\uD7B0-\uD7C6\uD7CB-\uD7FB\uF900-\uFAFF\uFE10-\uFE19\uFE30-\uFE52\uFE54-\uFE66\uFE68-\uFE6B\uFF01-\uFF60\uFFE0-\uFFE6]|[\uD800-\uDBFF][\uDC00-\uDFFF])/g;
+        var re = /(\t)|( +)|([\x00-\x1f\x80-\xa0\xad\u1680\u180E\u2000-\u200f\u2028\u2029\u202F\u205F\uFEFF\uFFF9-\uFFFC\u2066\u2067\u2068\u202A\u202B\u202D\u202E\u202C\u2069\u2060\u2061\u2062\u2063\u2064\u206A\u206B\u206B\u206C\u206D\u206E\u206F]+)|(\u3000+)/g;


This control-character class still includes U+200D (ZWJ) via the \u2000-\u200f range, so joined emoji like 👨‍👩‍👧‍👦 render chopped up by invalid-char dots. Splitting the range to \u2000-\u200C\u200E\u200f keeps ZWJ sequences intact and fixes #5813. (This is the one-character version of what I did in #5988.)

xyos · 2026-07-13T20:26:32Z

+                    var rects = getRects(child);
+                    for (var j = 0; j < rects.length; j++) {
+                        let rect = rects[j];
+                        if (rect.left < x && x < rect.left + rect.width) {


Strict inequalities here mean a click landing exactly on the seam between two spans (e.g. with showInvisibles on) matches neither child rect, falls through, and accumulates the wrong column. rect.left <= x && x <= rect.left + rect.width fixes it. Also worth clamping to column 0 when x is left of the line start; right now that path can return a large column.

xyos · 2026-07-13T20:26:32Z

+                        maxDistance = d;
+                    }
+                }
+                if (blockCursor) {


if (blockCursor) { // TODO } is a no-op, so vim block-cursor mode gets round-to-nearest instead of floor semantics. Either implement or drop the branch and note the limitation.

xyos · 2026-07-13T20:26:32Z


        var cursorTop = (pos.row - (onScreen ? this.config.firstRowScreen : 0)) *
            this.config.lineHeight;
+        var cursorWidth = this.config.fontMetrics.textWidth(pos.row, pos.column + 1) - textWidth;


If textWidth(col+1) and textWidth(col) measure equal (zero-width cluster tail, or a measurement fallback), cursorWidth is 0 and the cursor becomes invisible. Suggest (... - textWidth) || this.config.characterWidth.

xyos · 2026-07-13T20:26:32Z

-            this.updateBidiMap();
-        }
-        return this.bidiMap.bidiLevels;
+        return true;


isBidiRow now returns true for every row once the document contains any bidi character. One Hebrew word in a 10k-line file routes every marker on every line through drawBidiSingleLineMarker → getRects → DOM range measurement. A cheap per-line bidiRE.test(line) here would keep the fast path for the 99% of lines that aren't bidi.

xyos · 2026-07-13T20:26:32Z

+            if (useFontMetrics && this.$desiredColumn == null) {
+                offsetX = fontMetrics.textWidth(screenPos.row, screenPos.column);
+                if (isFinite(offsetX))
+                    this.$desiredColumn = offsetX / fontMetrics.config.characterWidth;


$desiredColumn now stores a fractional pixel-derived value (offsetX / characterWidth). When the target row isn't rendered, $pixelToColumn returns it unchanged and a non-integer column flows into screenToDocumentPosition. It works in the cases I tested, but rounding the fallback would keep the column contract integer-valued.

xyos · 2026-07-13T20:26:32Z

        }

-        var rowCount = 10;
+        var rowCount = 5.5;


rowCount = 5.5 looks like a leftover from testing fractional row heights; intentional?

xyos · 2026-07-13T20:30:54Z

    }

+    /**
+     * Calculates the width of the text up to a specific scrrenColumn on a given screen row.


nit: typo, scrrenColumn (also ends up in the generated types/ace-modules.d.ts)

xyos · 2026-07-13T20:30:55Z

+        var m0 = 0.7, m1 = 0.1, m2 = 0.3, m3 = 0.82;
+        var t1 = 100, t2 = 20;
+        function testTransform() {
+            fontMetrics.config.$transformData = null; //FIXME


nit: remove this comment

xyos · 2026-07-13T20:31:18Z

         * @related EditSession.documentToScreenPosition
         **/
-        screenToDocumentPosition(screenRow: number, screenColumn: number, offsetX?: number): Point;
+        screenToDocumentPosition(screenRow: number, screenColumn: number): Point;


This is a public API break: screenToDocumentPosition loses its documented offsetX param, and BidiHandler loses getPosLeft/getSelections/offsetToCol/updateCharacterWidths. Embedders calling these will break at runtime, not just in types. Probably fine given the old bidi pixel model is gone, but worth a changelog note and a decision on whether this ships as a minor or major bump.

xyos reviewed Feb 25, 2026

View reviewed changes

Comment thread src/layer/font_metrics.js Outdated

xyos reviewed Feb 25, 2026

View reviewed changes

Comment thread src/layer/font_metrics.js Outdated

xyos approved these changes Feb 26, 2026

View reviewed changes

nightwing force-pushed the varchar3 branch from 57a38ef to f9ab19a Compare March 23, 2026 23:51

nightwing mentioned this pull request Apr 27, 2026

Issues with Arabic Text Handling #5936

Open

nightwing force-pushed the varchar3 branch 3 times, most recently from c7be8dd to 90b4eee Compare May 2, 2026 08:37

nightwing force-pushed the varchar3 branch from 5a08e66 to bed0438 Compare May 3, 2026 14:06

nightwing force-pushed the varchar3 branch from 2de6037 to 6138c2d Compare May 5, 2026 14:08

nightwing mentioned this pull request May 18, 2026

improve getBoundingClientRect in mockdom #5973

Merged

mkslanc and others added 8 commits June 9, 2026 17:09

WIP: add text width measurement and cursor positioning based on pixel…

5203c96

… calculations # Conflicts: # src/virtual_renderer.js

text width calculation based on createRange

982731e

refactor

3c0e0c0

test

30ee806

address review comments

66b07cb

fix most of failing tests

108fe73

fix rendering of cjk spaces with show invisibles

685d2af

fix textinput tests

d5684d1

xyos mentioned this pull request Jul 3, 2026

Grapheme-cluster aware cursor, hit-testing and soft wrap on top of #5922 #5988

Open

nightwing force-pushed the varchar3 branch from 6138c2d to d7b2cdd Compare July 6, 2026 18:03

css transform support in mockdom

037318f

mkslanc and others added 6 commits July 8, 2026 18:03

fix: add width to fallback; remove unnesseccary check

0f32ef2

fix: improve text-to-screen coordinate calculation

0fbd29a

workaround for slow pixelToColumn on long tokens

6fb71cf

fix: remove unused offsetX parameter from `screenToDocumentPosition…

62bf8ce

…` and related methods

revert binary search changes as it doesn't work well with bidi text

23ffa01

nightwing force-pushed the varchar3 branch from d7b2cdd to a99a487 Compare July 8, 2026 17:23

nightwing force-pushed the varchar3 branch from a99a487 to 60ce0b1 Compare July 9, 2026 15:19

nightwing force-pushed the varchar3 branch from 60ce0b1 to 33d1040 Compare July 10, 2026 06:24

nightwing force-pushed the varchar3 branch from 33d1040 to 0e9e8be Compare July 10, 2026 07:03

nightwing force-pushed the varchar3 branch from 0e9e8be to fca477c Compare July 10, 2026 14:35

improve handling of bidi text

c6c9f87

nightwing force-pushed the varchar3 branch from fca477c to c6c9f87 Compare July 10, 2026 14:36

nightwing added 2 commits July 10, 2026 19:21

partial fix for horizontal scroll

7317a8f

update node in ci, since new typescript doesn't work with node 16

32ae297

fix multiline selection marker on wrapped bidi lines

40e5bdc

cleanup

8f9018c

xyos reviewed Jul 13, 2026

View reviewed changes

Uh oh!

Conversation

nightwing commented Feb 22, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xyos left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 2, 2026

Uh oh!

codecov Bot commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented May 2, 2026

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

github-actions Bot commented Jul 6, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

github-actions Bot commented Jul 12, 2026

Uh oh!

xyos left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

nightwing commented Feb 22, 2026 •

edited by github-actions Bot

Loading

codecov Bot commented May 2, 2026 •

edited

Loading

xyos left a comment •

edited

Loading